Extract controller setup, add console/sandbox image flags, and refine API types#3
Merged
Merged
Conversation
xrajesh
pushed a commit
to xrajesh/lightspeed-agentic-operator
that referenced
this pull request
May 10, 2026
…shift#8-11, openshift#13-17, #19-22, #29, #32) - openshift#1: Change status.attempts from *int32 to int32 with min=1/max=int32 validation - openshift#2: Move maxAttempts from ProposalSpec to ApprovalPolicy (admin ceiling) and ExecutionApproval (user choice); fix semantics so N = N total attempts - openshift#3: Remove spec.revision, use metadata.generation for revision signaling - openshift#4: Make ProposalStep.tools non-pointer with omitzero, add MinProperties=1 - openshift#8-11: Make outcome/result/conditionOutcome required; SandboxInfo fields required - openshift#13: Add CEL singleton rule (metadata.name == "cluster") on ApprovalPolicy - openshift#14: Use listType=map+listMapKey=name on ApprovalPolicy stages - openshift#15: Remove defaultOption from ApprovalPolicy (operator defaults to option 0) - #16-17: Add omitempty to name/approval, document allowed values - #19: Replace denied bool with decision enum (Approved|Denied) + CEL immutability - #20: Make ProposalApproval spec required - #21: Use listType=map+listMapKey=type on ProposalApproval stages - #22: Make estimatedImpact required on RemediationOption - #29: Remove components from ExecutionResult and VerificationResult (copy-paste error) - #32: Add MinProperties=1 to ToolsSpec Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
harche
changed the title
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
harche
changed the title
harche
force-pushed
the
wt/e2e-testing
branch
3 times, most recently
from
3b7dd51 to
55dd6ef
Compare
openshift-ci
Bot
added
the
needs-rebase
… API types - Extract controller wiring into controller/setup.go (Options struct with Namespace, AgenticConsoleImage, AgenticSandboxImage) - Add --agentic-console-image and --agentic-sandbox-image CLI flags to main.go, replacing hardcoded template references - Register OpenShift console/operator API schemes for ConsolePlugin reconciliation - Refine SkillsSource docs and make paths required (no whole-image mount) - Add defaultTools to Proposal spec for per-proposal tool defaults - Simplify sandbox agent caller setup - Update examples and docs to use find-token skill from quay.io/harpatil/agentic-skills:latest (TODO: replace with Konflux image) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
openshift-ci
Bot
removed
the
needs-rebase
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts controller setup into
controller/setup.goand adds--agentic-console-imageand--agentic-sandbox-imageCLI flags.🤖 Generated with Claude Code